[PATCH] splice : Must fully check for fifos

Hi Andrew

I think this patch is necessary. It's quite easy to crash a 2.6.19-rc4 box :(

AFAIK the problem come from inode-diet (by Theodore Ts'o, (2006/Sep/27))

Thank you

[PATCH] splice : Must fully check for FIFO

It appears that i_pipe, i_cdev and i_bdev share the same memory location 
(anonymous union in struct inode) since commits 
577c4eb09d1034d0739e3135fd2cff50588024be
eaf796e7ef6014f208c409b2b14fddcfaafe7e3a

Because of that, testing i_pipe being NULL is not anymore sufficient to tell 
if an inode is a FIFO or not.

Therefore, we must use the S_ISFIFO(inode->i_mode) test before assuming i_pipe 
pointer is pointing to a struct pipe_inode_info.

Signed-off-by: Eric Dumazet <[email protected]>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH] splice : Must fully check for fifos
    • From: Eric Dumazet <[email protected]>

• References:
  • [PATCH 1/2] lockdep: spin_lock_irqsave_nested()
    • From: Peter Zijlstra <[email protected]>
  • Re: [PATCH] splice : two smp_mb() can be omitted
    • From: Nick Piggin <[email protected]>
  • Re: [PATCH] splice : two smp_mb() can be omitted
    • From: Eric Dumazet <[email protected]>

• Prev by Date: Re: Can Linux live without DMA zone?
• Next by Date: Re: [PATCH] Fix user.* xattr permission check for sticky dirs
• Previous by thread: Re: [PATCH] splice : two smp_mb() can be omitted
• Next by thread: [PATCH] splice : Must fully check for fifos
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]