Re: [PATCH 1/8] cciss: version number change

["Mike Miller (OS Dev)" <mikem@beardog.cca.cpqcorp.net>]

On Thu, Nov 02, 2006 at 04:05:14PM +0100, Arjan van de Ven wrote:
> > This snippet seems to tbe the culprit.
> > +               if (blk_queue_stopped(h->gendisk[curr_queue]->queue) ||
> > +                   blk_queue_plugged(h->gendisk[curr_queue]->queue))
> > +                       blk_start_queue(h->gendisk[curr_queue]->queue);
> > 
> > We're testing to see if the queue is stopped or plugged so we don't
> > try to start am already running queue. Without the blk_queue_plugged
> > test it hangs every time. We added blk_queue_plugged and the first tests
> > seem to run ok. Then at the last minute something broke. Does this look
> > ok to you?
> 
> 
> it looks like a design mistake to me if a device driver needs to care
> about a queue being plugged at all....

We getting hw soon that will support up to 1024 logical volumes. We thought
the test would actually save time with many volumes. Maybe not.

mikem
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/