On 02/11/06, David Miller <[email protected]> wrote:
From: Jesper Juhl <[email protected]>
Date: Thu, 2 Nov 2006 01:21:53 +0100
> Since skb_dequeue() may return NULL we risk dereferencing a NULL pointer at
> if (!skb->sk)
> This patch avoids that by also testing for a NULL skb.
>
>
> Signed-off-by: Jesper Juhl <[email protected]>
It can't return NULL in this context because we just checked
skb_queue_empty() with the socket lock held and llc_wait_data()
will return zero only if skb_queue_empty() is false.
I know it's hard for automated tools to see this, but it's not
reasonable to put this extra check in there since it is
superfluous due to the above mentioned invariants.
Fair enough. Ignore the patch.
Thank you for the explanation.
--
Jesper Juhl <[email protected]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
