On Wed, 2006-11-01 at 10:48 -0800, Andrew Morton wrote:
> So it's failing here:
>
> static int device_add_class_symlinks(struct device *dev)
> {
> int error;
>
> if (!dev->class)
> return 0;
> error = sysfs_create_link(&dev->kobj, &dev->class->subsys.kset.kobj,
> "subsystem");
> if (error) {
> DB();
> goto out;
> }
> error = sysfs_create_link(&dev->class->subsys.kset.kobj, &dev->kobj,
> dev->bus_id);
> if (error) {
> -->> DB();
> goto out_subsys;
> }
>
>
> Now, prior to driver-core-fixes-sysfs_create_link-retval-checks-in.patch we
> were simply ignoring the return value of sysfs_create_link(). Now we're
> not ignoring it and stuff is failing.
>
> I'm suspecting that the second call to sysfs_create_link() in device_add():
>
>
> if (dev->class) {
> sysfs_create_link(&dev->kobj, &dev->class->subsys.kset.kobj,
> "subsystem");
> -->> sysfs_create_link(&dev->class->subsys.kset.kobj, &dev->kobj,
> dev->bus_id);
>
> is simply always failing, only we never knew about it.
>
> It would be useful if you could tell us what `error' is in there. Usually
> -EEXIST.
Yeah, they're all -EEXIST.
-Mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- Re: 2.6.19-rc3-mm1 -- missing network adaptors
- From: Andy Whitcroft <[email protected]>
- Re: 2.6.19-rc3-mm1 -- missing network adaptors
- From: "Martin J. Bligh" <[email protected]>
- Re: 2.6.19-rc3-mm1 -- missing network adaptors
- From: Andrew Morton <[email protected]>
- Re: 2.6.19-rc3-mm1 -- missing network adaptors
- From: Martin Bligh <[email protected]>
- Re: 2.6.19-rc3-mm1 -- missing network adaptors
- From: Andy Whitcroft <[email protected]>
- Re: 2.6.19-rc3-mm1 -- missing network adaptors
- From: Cornelia Huck <[email protected]>
- Re: 2.6.19-rc3-mm1 -- missing network adaptors
- From: Mike Galbraith <[email protected]>
- Re: 2.6.19-rc3-mm1 -- missing network adaptors
- From: "Martin J. Bligh" <[email protected]>
- Re: 2.6.19-rc3-mm1 -- missing network adaptors
- From: Greg KH <[email protected]>
- Re: 2.6.19-rc3-mm1 -- missing network adaptors
- From: Mike Galbraith <[email protected]>
- Re: 2.6.19-rc3-mm1 -- missing network adaptors
- From: Greg KH <[email protected]>
- Re: 2.6.19-rc3-mm1 -- missing network adaptors
- From: Mike Galbraith <[email protected]>
- Re: 2.6.19-rc3-mm1 -- missing network adaptors
- From: Mike Galbraith <[email protected]>
- Re: 2.6.19-rc3-mm1 -- missing network adaptors
- From: Mike Galbraith <[email protected]>
- Re: 2.6.19-rc3-mm1 -- missing network adaptors
- From: Andrew Morton <[email protected]>
- Re: 2.6.19-rc3-mm1 -- missing network adaptors
- From: Mike Galbraith <[email protected]>
- Re: 2.6.19-rc3-mm1 -- missing network adaptors
- From: Mike Galbraith <[email protected]>
- Re: 2.6.19-rc3-mm1 -- missing network adaptors
- From: Andrew Morton <[email protected]>
- Re: 2.6.19-rc3-mm1 -- missing network adaptors
- Prev by Date: Re: 2.6.19-rc <-> ThinkPads
- Next by Date: Re: [ckrm-tech] [RFC] Resource Management - Infrastructure choices
- Previous by thread: Re: 2.6.19-rc3-mm1 -- missing network adaptors
- Next by thread: Re: 2.6.19-rc3-mm1 -- missing network adaptors
- Index(es):
 |