Re: [PATCH] Add get_range, allows a hyhpenated range to get_options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Derek Fults wrote:
On Wed, 2006-11-01 at 08:57 -0800, Randy Dunlap wrote:
On Wed, 01 Nov 2006 10:22:36 -0600 Derek Fults wrote:

This allows a hyphenated range of positive numbers in the string passed
to command line helper function, get_options. Currently the command line option "isolcpus=" takes as its argument a list of cpus. Format: <cpu number>,...,<cpu number>
This can get extremely long when isolating the majority of cpus on a
large system.  Valid values of <cpu_number>  include all cpus, 0 to
"number of CPUs in system - 1".

Signed-off-by: Derek Fults <[email protected]>
Index: linux/lib/cmdline.c
===================================================================
--- linux.orig/lib/cmdline.c	2006-09-19 22:42:06.000000000 -0500
+++ linux/lib/cmdline.c	2006-11-01 10:16:09.988659834 -0600
@@ -16,6 +16,21 @@
 #include <linux/kernel.h>
 #include <linux/string.h>
+/* If a hyphen was found in get_option, this will handle the + * range of numbers given.
Still have trailing whitespace in the patch (2 lines above).

I think that this comment should explain that the M-N range
is handled by expanding it to an array of [M, M+1, ..., N].

How's this for a description?

/* If a hyphen was found in get_option, this will handle the
 * range of numbers, M-N.  This will expand the range and insert
 * the values[M, M+1, ..., N] into the ints array in get_options.
 */
That text is good.  Please look at lib/cmdline.c and put this text
into the same comment-block format as the rest of the file.

How does get_range() handle errors, like input of
	64-60
or	64-N
or	64-
?

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux