Re: [PATCH 1/2] Make x86_64 udelay() round up instead of down.

Hi!

> From: Paolo 'Blaisorblade' Giarrusso <[email protected]>
> 
> Port two patches from i386 to x86_64 delay.c to make sure all rounding is done
> upward instead of downward.
> 
> There is no sign in commit messages that the mismatch was done on purpose, and
> "delay() guarantees sleeping at least for the specified time" is still a valid
> rule IMHO.

> diff --git a/arch/x86_64/lib/delay.c b/arch/x86_64/lib/delay.c
> index 50be909..7514df0 100644
> --- a/arch/x86_64/lib/delay.c
> +++ b/arch/x86_64/lib/delay.c
> @@ -40,13 +40,13 @@ EXPORT_SYMBOL(__delay);
>  
>  inline void __const_udelay(unsigned long xloops)
>  {
> -	__delay((xloops * HZ * cpu_data[raw_smp_processor_id()].loops_per_jiffy) >> 32);
> +	__delay((xloops * HZ * cpu_data[raw_smp_processor_id()].loops_per_jiffy) >> 32 + 1);

Well, if this should be *rounding* up, you should do 

(xloops * HZ * cpu_data[raw_smp_processor_id()].loops_per_jiffy + 0xffffffff) >> 32

, no? Not sure if it matters...

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH 2/2] i386, x86_64: comment magic constants in delay.h
    • From: "Paolo 'Blaisorblade' Giarrusso" <[email protected]>
  • [PATCH 1/2] Make x86_64 udelay() round up instead of down - try2
    • From: "Paolo 'Blaisorblade' Giarrusso" <[email protected]>
  • Re: [PATCH 1/2] Make x86_64 udelay() round up instead of down.
    • From: Blaisorblade <[email protected]>

• References:
  • [PATCH 1/2] Make x86_64 udelay() round up instead of down.
    • From: "Paolo 'Blaisorblade' Giarrusso" <[email protected]>

• Prev by Date: Re: Ordering between PCI config space writes and MMIO reads?
• Next by Date: [PATCH 2/2] UML - Include tidying
• Previous by thread: [PATCH 2/2] i386, x86_64: comment magic constants in delay.h
• Next by thread: Re: [PATCH 1/2] Make x86_64 udelay() round up instead of down.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]