Re: [PATCH] Fix potential NULL pointer dereference in echoaudio midi.

On Tue, 31 Oct 2006, Jesper Juhl wrote:

> In sound/pci/echoaudio/midi.c::snd_echo_midi_output_write(), there's a risk
> of dereferencing a NULL 'chip->midi_out'.
> This patch contains the obvious fix as also used a bit higher up in the 
> same function.
> 

How about just adding an early test:
	if (!chip->midi_out)
		goto out;

and adding a label for out before the chip->lock unlock?  We still need to 
clear chip->midi_full so we still require the spinlock, but there's no 
reason we should be testing chip->midi_out multiple times since the 
remaining code path in its entirety depends on it.

		David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Fix potential NULL pointer dereference in echoaudio midi.
    • From: Jesper Juhl <[email protected]>

• References:
  • [PATCH] Fix potential NULL pointer dereference in echoaudio midi.
    • From: Jesper Juhl <[email protected]>

• Prev by Date: SCSI over USB showstopper bug?
• Next by Date: Re: [PATCH] splice : two smp_mb() can be omitted
• Previous by thread: [PATCH] Fix potential NULL pointer dereference in echoaudio midi.
• Next by thread: Re: [PATCH] Fix potential NULL pointer dereference in echoaudio midi.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]