From: Christoph Hellwig <[email protected]>
Date: Mon, 30 Oct 2006 15:15:01 +0100
> Davem suggested to get the node-affinity information directly from
> struct device instead of having the caller extreact it from the
> pci_dev. This patch adds dev_to_node() to the topology API for that.
> The implementation is rather ugly as we need to compare the bus
> operations which we can't do inline in a header without pulling all
> kinds of mess in.
>
> Thus provide an out of line dev_to_node for ppc and let everyone else
> use the dummy variant in asm-generic.h for now.
>
> Signed-off-by: Christoph Hellwig <[email protected]>
It may be a bit much to be calling all the way through up to the PCI
layer just to pluck out a simple integer, don't you think? The PCI
bus pointer comparison is just a symptom of how silly this is.
Especially since this will be used for every packet allocation a
device makes.
So, please add some sanity to this situation and just put the node
into the generic struct device. :-)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
