Re: [PATCH] xacct_add_tsk: fix pure theoretical ->mm use-after-free

On 10/30, Jay Lan wrote:
>
> Oleg Nesterov wrote:
> > Paranoid fix. The task can free its ->mm after the 'if (p->mm)' check.
> 
> Why this change is necessary? This routine is indirectly invoked by
> taskstats_exit_send() routine called inside do_exit():

Not only, please note

	taskstats_user_cmd(TASKSTATS_CMD_ATTR_PID)->fill_pid()->xacct_add_tsk()

path. This tsk is not 'current', it was found by find_task_by_pid(), and
it may exit at any time.

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] xacct_add_tsk: fix pure theoretical ->mm use-after-free
    • From: Jay Lan <[email protected]>

• References:
  • [PATCH] xacct_add_tsk: fix pure theoretical ->mm use-after-free
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH] xacct_add_tsk: fix pure theoretical ->mm use-after-free
    • From: Jay Lan <[email protected]>

• Prev by Date: Re: [ckrm-tech] [RFC] Resource Management - Infrastructure choices
• Next by Date: Re: [PATCH] vmalloc : optimization, cleanup, bugfixes
• Previous by thread: Re: [PATCH] xacct_add_tsk: fix pure theoretical ->mm use-after-free
• Next by thread: Re: [PATCH] xacct_add_tsk: fix pure theoretical ->mm use-after-free
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]