On Sun, Oct 29, 2006 at 03:15:59PM -0500, Trond Myklebust wrote:
> > +void svcauth_gss_unregister_pseudoflavor(char *name)
> > +{
> > + struct auth_domain *dom;
> > +
> > + dom = auth_domain_find(name);
> > + if (dom) {
> > + auth_domain_put(dom);
> > + auth_domain_put(dom);
> > + }
> > +}
>
> Strictly speaking, if you want to be smp-safe, you probably need
> something like the following:
>
> dom = auth_domain_find(name);
> if (dom) {
> spin_lock(&auth_domain_lock);
> if (!hlist_unhashed(dom->hash)) {
> hlist_del_init(dom->hash);
> spin_unlock(&auth_domain_lock);
> auth_domain_put(dom);
> } else
> spin_unlock(&auth_domain_lock);
> auth_domain_put(dom);
> }
>
> and then add a test for hlist_unhashed into auth_domain_put(). If not,
> some other processor could race you inside
> svcauth_gss_unregister_pseudoflavor.
But auth_domain_table is protected by auth_domain_lock while we are
using auth_domain_put()/auth_domain_lookup()/auth_domain_find().
So I think there is not big difference.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
