Can you add a high level comment to entry.S what paravirt mode
is all about and perhaps a quick cheat sheet on the macros?
> +/* SMP boot always wants to use real time delay to allow sufficient time
> for + * the APs to come online */
> +#define USE_REAL_TIME_DELAY
That's ugly. Can't you call different wait functions for that case instead?
> +#ifdef CONFIG_PARAVIRT
> +#include <asm/paravirt.h>
> +#else
> +static inline void init_IRQ(void)
> +{
> + native_init_IRQ();
> +}
> +#endif /* CONFIG_PARAVIRT */
You could probably avoid a lot of ifdefs by strategic use of
__attribute__((weak))
> +#ifdef CONFIG_PARAVIRT
> +#include <asm/paravirt.h>
> +#else
This is probably a good candidate for rename to native + wrapper
macros too. Otherwise we'll always have to hack two different
places later.
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
