Re: [take21 2/4] kevent: poll/select() notifications.

On Sat, Oct 28, 2006 at 12:04:10PM +0200, Eric Dumazet ([email protected]) wrote:
> Evgeniy Polyakov a écrit :
> 
> >+	file = fget(k->event.id.raw[0]);
> >+	if (!file)
> >+		return -ENODEV;
> 
> Please, do us a favor, and use EBADF instead of ENODEV.
> 
> EBADF : /* Bad file number */
> 
> ENODEV : /* No such device */
> 
> You have many ENODEV uses in your patches and that really hurts.

Ok :)

> Eric

-- 
	Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [take21 2/4] kevent: poll/select() notifications.
    • From: Evgeniy Polyakov <[email protected]>
  • Re: [take21 2/4] kevent: poll/select() notifications.
    • From: Eric Dumazet <[email protected]>

• Prev by Date: Re: feature-removal-schedule obsoletes
• Next by Date: Re: linux-2.6.19-rc2 PCI problem
• Previous by thread: Re: [take21 2/4] kevent: poll/select() notifications.
• Next by thread: Re: [take21 1/4] kevent: Core files.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]