Re: [PATCH cciss: fix printk format warning

• To: Andrew Morton <[email protected]>
• Subject: Re: [PATCH cciss: fix printk format warning
• From: Roland Dreier <[email protected]>
• Date: Thu, 26 Oct 2006 16:19:56 -0700
• Authentication-results: sj-dkim-8.cisco.com; [email protected]; dkim=pass ( sig from cisco.com verified; );
• Cc: Randy Dunlap <[email protected]>, [email protected], lkml <[email protected]>
• Dkim-signature: a=rsa-sha1; q=dns; l=271; t=1161904799; x=1162768799; c=relaxed/relaxed; s=sjdkim8002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; [email protected]; z=From:Roland=20Dreier=20<[email protected]> |Subject:Re=3A=20[PATCH=20cciss=3A=20fix=20printk=20format=20warning; X=v=3Dcisco.com=3B=20h=3Din+jLTThoFmcHm3XzZrwG+iMEM8=3D; b=JTjUjEylV0nzjBKFBXTv6iKY6rfyrBmEg3mNQ5zd1QuZMJ9DEtS9sG0y2AFB9FvR7cbTLFXZ 0VHe66e0NQVQWcxLwa8Dig34OWnvYNrfAI7d3sAjdH/ODS3t4f7ikvbU;
• In-reply-to: <[email protected]> (Andrew Morton's message of "Thu, 26 Oct 2006 16:02:45 -0700")
• References: <[email protected]> <[email protected]>
• Sender: [email protected]
• User-agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.18 (linux)

 > >  	if (*total_size != (__u32) 0)
 > 
 > Why is cciss_read_capacity casting *total_size to u32?

It's not -- it's actually casting 0 to __32 -- there's no cast on the
*total_size side of the comparison.  However that just makes the cast
look even fishier.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH cciss: fix printk format warning
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH cciss: fix printk format warning
    • From: Randy Dunlap <[email protected]>

• References:
  • [PATCH cciss: fix printk format warning
    • From: Randy Dunlap <[email protected]>
  • Re: [PATCH cciss: fix printk format warning
    • From: Andrew Morton <[email protected]>

• Prev by Date: 2.6.18 forcedeth GSO panic on send
• Next by Date: [PATCH 0/6] taskstats fixes
• Previous by thread: Re: [PATCH cciss: fix printk format warning
• Next by thread: Re: [PATCH cciss: fix printk format warning
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]