Re: [Q] missing unused dentry in prune_dcache()?

Vasily Averin <[email protected]> wrote:

> I would note that in first two hunks you have decremented
> dentry_stat.nr_unused correctly, under dcache_lock. Probably it's better to
> count freed dentries only in third case and corrects dentry_stat.nr_unused
> value inside shrink_dcache_for_umount_subtree() function before return.

Maybe, maybe not.  This way we only touch the dentry_stat cacheline once, if
at all.  I'm not sure it'd make much difference though.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- Re: [Q] missing unused dentry in prune_dcache()?
  - From: Vasily Averin <[email protected]>
- Re: [Q] missing unused dentry in prune_dcache()?
  - From: Vasily Averin <[email protected]>
- [Q] missing unused dentry in prune_dcache()?
  - From: Vasily Averin <[email protected]>
- Re: [Q] missing unused dentry in prune_dcache()?
  - From: David Howells <[email protected]>

Prev by Date: Re: [Patch 0/5] I/O statistics through request queues
Next by Date: Re: Another kernel releated GPL ?
Previous by thread: Re: [Q] missing unused dentry in prune_dcache()?
Next by thread: Re: [Q] missing unused dentry in prune_dcache()?
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]