Re: [PATCH 2.6.19-rc3 2/2] ehea: 64K page support fix

Hi,

that is right, I'll send a new patch

Thanks,
Jan-Bernd

On Wednesday 25 October 2006 18:21, Anton Blanchard wrote:
> 
> Hi,
> 
> > +#ifdef CONFIG_PPC_64K_PAGES
> > +	/* To support 64k pages we must round to 64k page boundary */
> > +	epas->kernel.addr =
> > +		ioremap((paddr_kernel & 0xFFFFFFFFFFFF0000), PAGE_SIZE) +
> > +		(paddr_kernel & 0xFFFF);
> > +#else
> >  	epas->kernel.addr = ioremap(paddr_kernel, PAGE_SIZE);
> > +#endif
> 
> Cant you just use PAGE_MASK, ~PAGE_MASK and remove the ifdefs
> completely?
> 
> Anton
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 2.6.19-rc3 2/2] ehea: 64K page support fix
    • From: Jan-Bernd Themann <[email protected]>
  • Re: [PATCH 2.6.19-rc3 2/2] ehea: 64K page support fix
    • From: Anton Blanchard <[email protected]>

• Prev by Date: Re: [PATCH] x86_64: Some vmlinux.lds.S cleanups
• Next by Date: Re: [Q] missing unused dentry in prune_dcache()?
• Previous by thread: Re: [PATCH 2.6.19-rc3 2/2] ehea: 64K page support fix
• Next by thread: [Q] missing unused dentry in prune_dcache()?
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]