Re: Touchscreen hardware hacking/driver hacking.

["Dmitry Torokhov" <dtor@insightbb.com>]

Hi Greg,

On 10/25/06, Greg.Chandler@wellsfargo.com <Greg.Chandler@wellsfargo.com> wrote:
> I've been thinking about the code I added:
>        {
>                .ident = "FLORA-ie 55mi",
>                .matches = {
>                        DMI_MATCH(DMI_PRODUCT_NAME, "FLORA-ie 55mi"),
>                },
>        },
>
> That's nice and all that it works

Great!

> but I'd like to make it work for all
> models.  Some don't return the same strings, but do have the same
> hardware.  I noticed the same thing with your lifebook models.
> I can't find the definition for "DMI_MATCH"

inlude/linux/dmi.h

> , of if I did, I sure don't
> understand it.  What I'd like to do is something along the lines of:
>
> const char* UPCASEME(string str)
>  {
>    for (int x = 0; x < str.size(); x = x + 1)
>      {
>        str[x] = toupper(str[x]);
>      }
>    return str.c_str();
>  }
>
> {
>  if (strncmp(UPCASEME(DMI_PRODUCT_NAME), UPCASEME("FLORA-ie ") ,9) ==
> 0)

DMI_PRODUCT_NAME is number of field in DMI tables containing product
name, it is a number and can't be upcased ;)

<...skip...>
> int dmi_check_system(struct dmi_system_id *list)
>
> If this is true, maybe that function should be changed to make it
> case-insensitive?
> If so then, 4 of the pre-existing cases can be summed up as "LifeBook
> B", and all of the Flora-ie tablets can be listed as a single entry as
> well.
>
> I know somone will object to this as a dangerous assumption that all
> models, or all spellings are the same.  Byt the time the flames hit, I
> should have my asbestos armour out and ready.  However, I know for a
> fact that all of the Hitachi tablets do have this, and for what I have
> read so do the lifebooks.  My opinion is that "it's only a PS/2" driver,
> what could go wrong.

It was considered but we decided that if we need to rely on solely DMI
data when activating some features we need to add models one by one
and do not use "blanket" options. There are lifebooks out there that
do not have that kind of outscreen so if we tried to match just on
"LIFEBOOK" present in the product name we might hit such models and
then their PS/2 mice would not work.

If we knew of a way to query the touchscreen for lifebook protocol
support that would be a different story...

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/