Re: [PATCH] x86_64 irq: reset more to default when clear irq_vector for destroy_irq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I cut the code paste the lines from __assign_irq_vector().

It seems we need to change
   if (old_vector >= 0) {
in __assign_irq_vector with this one to
   if (old_vector > 0) {
later.   Eric?

YH




The two conditionals don't complement each other; in fact, only one
conditional is required since the test for old_vector equality to zero
will never be satisfied.  Also note that irq_vectors are u8 on x86_64 and
not ints.

        static void __clear_irq_vector(int irq)
        {
                u8 old_vector = irq_vector[irq];
                if (old_vector > 0) {
                        cpumask_t old_mask;
                        int old_cpu;
                        cpus_and(old_mask, irq_domain[irq], cpu_online_map);
                        for_each_cpu_mask(old_cpu, old_mask)
                                per_cpu(vector_irq, old_cpu)[old_vector] = -1;
                }
                irq_vector[irq] = 0;
                irq_domain[irq] = CPU_MASK_NONE;
        }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux