From: [email protected] [mailto:[email protected]] >Beyond that I have a few nits to pick with the patch. >- We duplicate the code that claims a new vector which makes > maintenance a pain. >- The comments are specific to phys_flat but the code is not. >- The test for being able to use the old_vector in the new domain > should be: ...[old_vector] == vector || ...[old_vector] == -1 Please attached one. This one need to after your patch about irq. YH
Attachment:
io_apic_reuse_vector.diff
Description: io_apic_reuse_vector.diff
- Follow-Ups:
- Prev by Date: Re: 2.6.19-rc2: known unfixed regressions (v3)
- Next by Date: Re: 2.6.19-rc2-mm2: reproducible hang on shutdown on i386
- Previous by thread: Re: [PATCH] x86_64 irq: reuse vector for set_xxx_irq_affinity in phys flat mode
- Next by thread: Re: [PATCH] x86_64 irq: reuse vector for set_xxx_irq_affinity in phys flat mode
- Index(es):
 |