Re: [PATCH 8/13] KVM: vcpu execution loop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Arnd Bergmann wrote:
On Monday 23 October 2006 22:16, Avi Kivity wrote:
This looks like you should simply put it into a .S file.

Then I lose all the offsetof constants down the line.  Sure, I could do
the asm-offsets dance but it seems to me like needless obfuscation.

Ok, I see.

How if you pass &vcpu->regs and &vcpu->cr2 to the functions instead of kvm_vcpu?


I could do that, but I feel that's more brittle. I might need more (or other) fields later on. It will also cost me more pushes on the stack (no real performance or space impact, just C64-era frugality).


--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux