Re: [KJ] [PATCH] Correct misc_register return code handling in several drivers

On 10/23/06, Neil Horman <[email protected]> wrote:

+out3:
+       for_each_online_node(node) {
+               if(timers[node] != NULL)
+                       kfree(timers[node]);
+       }

Tharindu is going to be unhappy out if he sees that.  There is a
possibility that timers[node] is uninitialized.  if node[0] is null
then node[1] is uninitialized and it's going to cause a crash.

regards,
dan carpenter
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [KJ] [PATCH] Correct misc_register return code handling in several drivers
    • From: Neil Horman <[email protected]>

• References:
  • [KJ][PATCH] Correct misc_register return code handling in several drivers
    • From: Neil Horman <[email protected]>

• Prev by Date: Re: [KJ][PATCH] Correct misc_register return code handling in several drivers
• Next by Date: Re: [PATCH] Freeze bdevs when freezing processes.
• Previous by thread: Re: [KJ][PATCH] Correct misc_register return code handling in several drivers
• Next by thread: Re: [KJ] [PATCH] Correct misc_register return code handling in several drivers
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]