[PATCH] do_acct_process: don't take tty_mutex

Depends on
	tty-signal-tty-locking.patch

No need to take the global tty_mutex, signal->tty->driver can't go away
while we are holding ->siglock.

Signed-off-by: Oleg Nesterov <[email protected]>

--- rc2-mm2/kernel/acct.c~	2006-10-22 19:28:17.000000000 +0400
+++ rc2-mm2/kernel/acct.c	2006-10-23 17:09:12.000000000 +0400
@@ -484,12 +484,9 @@ static void do_acct_process(struct file 
 	ac.ac_ppid = current->parent->tgid;
 #endif
 
-	mutex_lock(&tty_mutex);
-	tty = get_current_tty();
-	ac.ac_tty = tty ? old_encode_dev(tty_devnum(tty)) : 0;
-	mutex_unlock(&tty_mutex);
-
 	spin_lock_irq(&current->sighand->siglock);
+	tty = current->signal->tty;
+	ac.ac_tty = tty ? old_encode_dev(tty_devnum(tty)) : 0;
 	ac.ac_utime = encode_comp_t(jiffies_to_AHZ(cputime_to_jiffies(pacct->ac_utime)));
 	ac.ac_stime = encode_comp_t(jiffies_to_AHZ(cputime_to_jiffies(pacct->ac_stime)));
 	ac.ac_flag = pacct->ac_flag;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] do_acct_process: don't take tty_mutex
    • From: Peter Zijlstra <[email protected]>

• Prev by Date: Re: 2.6.19-rc2: ieee80211/ipw2200 regression
• Next by Date: Re: [PATCH 1/6] bit revese library
• Previous by thread: [PATCH 0/7] KVM: Kernel-based Virtual Machine (v2)
• Next by thread: Re: [PATCH] do_acct_process: don't take tty_mutex
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]