Re: [PATCH 2.6.19-rc2] sound/oss/i810_audio.c: check kmalloc() return value.

On 10/23/06, Amit Choudhary <[email protected]> wrote:

@@ -2580,8 +2580,13 @@ static int i810_open(struct inode *inode
                        if (card->states[i] == NULL) {
                                state = card->states[i] = (struct i810_state *)
                                        kmalloc(sizeof(struct i810_state), GFP_KERNEL);
-                               if (state == NULL)
+                               if (state == NULL) {
+                                       for (--i; i >= 0; i--) {
+                                               kfree(card->states[i]);
+                                               card->states[i] = NULL;
+                                       }
                                        return -ENOMEM;
+                               }
                                memset(state, 0, sizeof(struct i810_state));
                                dmabuf = &state->dmabuf;
                                goto found_virt;

Looks wrong to me. We only allocate memory once in the loop (hint:
goto found_virt at the bottom here).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 2.6.19-rc2] sound/oss/i810_audio.c: check kmalloc() return value.
    • From: Amit Choudhary <[email protected]>

• Prev by Date: Re: dealing with excessive includes
• Next by Date: Re: [PATCH 2.6.19-rc2] mm/slab.c: check kmalloc() return value.
• Previous by thread: [PATCH 2.6.19-rc2] sound/oss/i810_audio.c: check kmalloc() return value.
• Next by thread: incorrect taint of ndiswrapper
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]