Re: [PATCH 2.6.19-rc2] sound/oss/i810_audio.c: check kmalloc() return value.

["Pekka Enberg" <penberg@cs.helsinki.fi>]

On 10/23/06, Amit Choudhary <amit2030@gmail.com> wrote:
> @@ -2580,8 +2580,13 @@ static int i810_open(struct inode *inode
>                         if (card->states[i] == NULL) {
>                                 state = card->states[i] = (struct i810_state *)
>                                         kmalloc(sizeof(struct i810_state), GFP_KERNEL);
> -                               if (state == NULL)
> +                               if (state == NULL) {
> +                                       for (--i; i >= 0; i--) {
> +                                               kfree(card->states[i]);
> +                                               card->states[i] = NULL;
> +                                       }
>                                         return -ENOMEM;
> +                               }
>                                 memset(state, 0, sizeof(struct i810_state));
>                                 dmabuf = &state->dmabuf;
>                                 goto found_virt;

Looks wrong to me. We only allocate memory once in the loop (hint:
goto found_virt at the bottom here).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/