On Sat, Oct 21, 2006 at 04:13:28PM -0700, David Rientjes wrote:
> > +static void __init calgary_increase_split_completion_timeout(void __iomem *bbar,
> > + unsigned char busnum)
> > +{
> > + u64 val64;
> > + void __iomem *target;
> > + unsigned long phb_shift = -1;
>
> The initialization of this to -1 is unclear to me since we fall through to
> BUG_ON() if busno_to_phbid() returns anything under than 0-3. A shift
> value of MAX_ULONG is never appropriate.
Without the initialization gcc warns about 'phb_shift' potentially
being used unitialized. I used '-1' exactly because it is never
appropriate.
Cheers,
Muli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
