Re: [PATCH 2.6.19-rc2] [REVISED 2] drivers/media/video/se401.c: check kmalloc() return value.

Ar Iau, 2006-10-19 am 22:16 -0700, ysgrifennodd Amit Choudhary:
> Description: Check the return value of kmalloc() in function se401_start_stream(), in file drivers/media/video/se401.c.
> 
> Signed-off-by: Amit Choudhary <[email protected]>

This actually isn't needed for the first case as SE401_NUMSBUF is 1 but
the second fix is needed. Both are right and useful to merge in case
NUMSBUF is ever changed.

If you know se401->sbuf[] and se401->scratch , urb etc are being cleared
to NULL (or you did that) you could just use the kfree loops in nomem_
for all cases as kfree(NULL) is an allowed "no-op"


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH 2.6.19-rc2] [REVISED 2] drivers/media/video/se401.c: check kmalloc() return value.
  - From: Amit Choudhary <[email protected]>

References:
- [PATCH 2.6.19-rc2] [REVISED 2] drivers/media/video/se401.c: check kmalloc() return value.
  - From: Amit Choudhary <[email protected]>

Prev by Date: Re: ASUS M2NPV-VM APIC/ACPI Bug (patched)
Next by Date: [PATCH 3/3] Enforce "unsigned long flags;" when spinlocking
Previous by thread: [PATCH 2.6.19-rc2] [REVISED 2] drivers/media/video/se401.c: check kmalloc() return value.
Next by thread: Re: [PATCH 2.6.19-rc2] [REVISED 2] drivers/media/video/se401.c: check kmalloc() return value.
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]