Re: [PATCH 4/6] net: use bitrev8

[Michael Tokarev <mjt@tls.msk.ru>]

Andrew Morton wrote:
> On Thu, 19 Oct 2006 01:46:47 +0900
> Akinobu Mita <akinobu.mita@gmail.com> wrote:
> 
>> Use bitrev8 for bmac, mace, macmace, macsonic, and skfp drivers.
>>
[]
>> ===================================================================
>> --- work-fault-inject.orig/drivers/net/Kconfig
>> +++ work-fault-inject/drivers/net/Kconfig
>> @@ -2500,6 +2500,7 @@ config DEFXX
>>  config SKFP
>>  	tristate "SysKonnect FDDI PCI support"
>>  	depends on FDDI && PCI
>> +	select BITREVERSE
>>  	---help---
>>  	  Say Y here if you have a SysKonnect FDDI PCI adapter.
>>  	  The following adapters are supported by this driver:
> 
[]
> But select is problematic and I do wonder whether it'd be simpler to just
> link the thing into vmlinux.

Why it's problematic?  Maintenance costs of various missing selects?
I don't want extra stuff in kernel (vmlinux) if it's not used.

/mjt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/