Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

Andi Kleen wrote:

<snip>
> Thanks. But the code should be probably common somewhere in fs/*, not
> duplicated.
<snip>

Thank you for the comment!
I'm not sure we should do it. If we move the code in fs/quota.c for example,
than this code will be compiled for _all_ arhitectures, not only for x86_64 and ia64.
Of course, we can surround this code by #ifdefs <ARCH>, but I thought this is 
a bad style... Moreover looking through current kernel code, I found out that
usually code is duplicated in such cases.

However, if you insist I'll modify the code! :)

Thank you.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures
    • From: Andi Kleen <[email protected]>
  • Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures
    • From: Christoph Hellwig <[email protected]>

• References:
  • [PATCH] diskquota: 32bit quota tools on 64bit architectures
    • From: Vasily Tarasov <[email protected]>
  • Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures
    • From: Andi Kleen <[email protected]>

• Prev by Date: Re: Git training wheels for the pimple faced maintainer
• Next by Date: Re: Git training wheels for the pimple faced maintainer
• Previous by thread: Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures
• Next by thread: Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]