Re: [PATCH] account_system_vtime() should be a macro, not a function

On Thursday 19 October 2006 15:43, Eric Dumazet wrote:
> [PATCH] account_system_vtime() should be a macro, not a function
> 
> Because the way 'current' is implemented on some archs, it's better to use a 
> null macro for account_system_vtime(current) 
> 
> I discovered that gcc was (correctly) issuing one useless instruction (to 
> load %rax with current from pda) on x86_64 on irq_enter() and __irq_exit()
> 
> This saves few bytes in kernel size, on archs where current is 'asm volatile'

I dropped the asm volatile on x86-64 some time ago. Perhaps it should
be dropped on the other architectures too.  Then such hacks wouldn't
be needed anywhere.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [Bug 185] Sometimes kernel freezes sometime lists OOPS - hostap_cs
    • From: CIJOML <[email protected]>
  • Re: [Bug 185] Sometimes kernel freezes sometime lists OOPS - hostap_cs
    • From: Andrew Morton <[email protected]>
  • [PATCH] account_system_vtime() should be a macro, not a function
    • From: Eric Dumazet <[email protected]>

• Prev by Date: Re: + i386-time-avoid-pit-smp-lockups.patch added to -mm tree
• Next by Date: [PATCH 0/7] KVM: Kernel-based Virtual Machine
• Previous by thread: [PATCH] account_system_vtime() should be a macro, not a function
• Next by thread: [PATCH] Re: UNWIND_INFO slowdown in -mm1
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]