On Wed, 2006-10-18 at 16:33 +0200, Ingo Molnar wrote:
> * Daniel Walker <[email protected]> wrote:
>
> > On Wed, 2006-10-18 at 09:28 +0200, Ingo Molnar wrote:
> > > * Daniel Walker <[email protected]> wrote:
> > >
> > > > Pay close attention to the fasteoi interrupt threading. I added usage
> > > > of mask/unmask instead of using level handling, which worked well on
> > > > PPC.
> > >
> > > this is wrong - it should be doing mask+ack.
> >
> > The main reason I did it this way is cause the current threaded eoi
> > expected the line to be masked. So if you happen to have a eoi that's
> > threaded you get a warning then the interrupt hangs.
>
> does that in fact happen on -rt6? If yes, could you send the warning
> that is produced?
>
> Ingo
The warning was the WARN_ON_ONCE from the section below (which is gone
is -rt6)
if (redirect_hardirq(desc)) {
- WARN_ON_ONCE(1);
+ mask_ack_irq(desc, irq);
goto out_unlock;
}
+
I haven't tried it, but I'd think it will work. That's assuming you have
an "ack" which I hear some PowerPC don't (Benjamin Herrenschmidt talked
about having no "ack" when discussing fasteoi a few month back).
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
