Re: fsstack: struct path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 18, 2006 at 09:35:27AM +0100, Al Viro wrote:
> On Wed, Oct 18, 2006 at 01:31:03AM -0700, Andrew Morton wrote:
> > > One, rather unfortunate, fact is that struct path is also defined in
> > > include/linux/reiserfs_fs.h as something completely different - reiserfs
> > > specific.
> > > 
> > > Any thoughts?
> > > 
> > 
> > reiserfs is being bad.  s/path/reiserfs_path/g
> 
> Indeed.  That's one pending patch that never got around to be submitted
> (and had bitrotten at least 3 times, IIRC).
> 
> ACK, provided that reiserfs folks are OK with the replacement name for
> their struct.  Note that "path" in question has very little to do with
> pathnames - it's a path in balanced tree, IIRC.  So if we get around
> to renaming that sucker, it might be a good time to pick better name.

Aside from having to reindent the reiserfs tree afterwards, I doubt
anyone would mind (please cc reiserfs-dev on the patch though).  Al is
right, it's a path in the balanced tree.

-chris

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux