Re: [PATCH] x86_64 add NX mask for PTE entry

Also I think change_page_attr is buggy. if orginal page is not
large page, when that page's previous attr is reverted revert_page()
function will be called to make that page huge. Indeed I think
there is no need to do this.

thanks
bibo,mao

bibo,mao wrote:

Andi Kleen wrote:

On Wednesday 18 October 2006 11:15, bibo,mao wrote:

Hi,
    If function change_page_attr_addr calls revert_page to revert
to original pte value, mk_pte_phys does not mask NX bit. If NX bit
is set on no NX hardware supported x86_64 machine, there is will
be RSVD type page fault and system will crash. This patch adds NX
mask bit for PTE entry.

Hmm, weird. I wonder why that didn't trip up earlier. Did you

actually see that happening?

I remember previous system worked well on 2.6.12 and 2.6.13 version,
but recently even on older kernel(2.6.9) there will be many times of
page fault error and system crashes at last when rebooting system.

I will paste the oops message tomorrow.

thanks
bibo,mao

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] x86_64 add NX mask for PTE entry
    • From: Andi Kleen <[email protected]>

• References:
  • [PATCH] x86_64 add NX mask for PTE entry
    • From: "bibo,mao" <[email protected]>
  • Re: [PATCH] x86_64 add NX mask for PTE entry
    • From: Andi Kleen <[email protected]>
  • Re: [PATCH] x86_64 add NX mask for PTE entry
    • From: "bibo,mao" <[email protected]>

• Prev by Date: [PATCH] arm fix for kernel with Realtime Preempt patch
• Next by Date: Re: Bandwidth Allocations under CFQ I/O Scheduler
• Previous by thread: Re: [PATCH] x86_64 add NX mask for PTE entry
• Next by thread: Re: [PATCH] x86_64 add NX mask for PTE entry
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]