On Tue, 17 Oct 2006, Cornelia Huck wrote:
> From: Cornelia Huck <[email protected]>
>
> Don't fail bus_attach_device(), even if the device cannot be bound.
>
> If dev->driver has been specified, reset it to NULL if device_bind_driver()
> failed and add the device as an unbound device. As a result, bus_attach_device()
> now cannot fail, and we can remove some checking from device_add().
>
> Also remove an unneeded check in bus_rescan_devices_helper().
The other patches look good, and so does this one except for one small
thing:
> -int bus_attach_device(struct device * dev)
> +void bus_attach_device(struct device * dev)
> {
> struct bus_type *bus = dev->bus;
> - int ret = 0;
> + int ret;
>
> if (bus) {
> dev->is_registered = 1;
> ret = device_attach(dev);
> - if (ret >= 0) {
> + BUG_ON(ret < 0);
> + if (ret >= 0)
> klist_add_tail(&dev->knode_bus, &bus->klist_devices);
> - ret = 0;
> - } else
> + else
> dev->is_registered = 0;
It looks odd to test the value of ret when you've just crashed the system
if ret < 0. You probably should change the BUG_ON to a WARN_ON or
something similar.
Alan Stern
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
