Re: Re: [PATCH 2/2] 2.6.19-rc1-mm1 pktcdvd: bio write congestion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 16 Oct 2006, [email protected] wrote:

the congestion control will work with both code changes, but i am
not sure, if using clear_queue_congested() and blk_congestion_wait()
is the right thing to use here: it works on global level. Any other
thread/driver/etc. can do a clear_queue_congested() and wake
up anyone waiting on this global write or read wait queue, resulting to
unneeded task switches.
The driver local solution (own waitqueue) would prevent this.....

But it would make the driver more complex. How many extra task switches can you get, and how much CPU time does that consume? If it is negligible I think it's better to keep the code simple.

--
Peter Osterlund - [email protected]
http://web.telia.com/~u89404340
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux