On Mon, 16 Oct 2006 10:08:50 +1000 Neil Brown wrote:
> On Friday October 13, [email protected] wrote:
> > Ar Gwe, 2006-10-13 am 09:50 +1000, ysgrifennodd Neil Brown:
> > > So: Is there any good reason to not clip the partitions to fit
> > > within the device - and discard those that are completely beyond
> > > the end of the device??
> >
> > Its close but not quite the right approach
> >
> > > The patch at the end of the mail does that. Is it OK to submit this
> > > to mainline?
> >
> > No I think not. Any partition which is partly outside the disk should be
> > ignored entirely, that ensures it doesn't accidentally get mounted and
> > trashed by an HPA or similar mixup.
>
> Hmmm.. So Alan things a partially-outside-this-disk partition
> shouldn't show up at all, and Andries thinks it should.
> And both give reasonably believable justifications.
>
> Maybe we need a kernel parameter? How about this?
>
> NeilBrown
>
>
> -----------------------------
> Don't allow partitions to start or end beyond the end of the device.
>
> Corrupt partitions tables can cause wierd partitions that confuse
> programs. This is confusion that can be avoided.
>
> If a partition appears to start at or beyond the end of a device, we
> don't enable it.
> If it starts within the device but ends after the end, we clip it to
> fit within the device.
>
> Not enabling partitions does not affect partition numbering of
> subsequent partitions.
>
> This change applies to partitions found by fs/partitions/check.c
> and to partitions explicitly created via an ioctl.
>
> There is no uniform agreement on whether partitions that extend
> beyond the end of the device should be clipped or discarded.
> Discarding is safer as it makes corruption less likely.
> Clipping is more flexable and gives continued access to the partition.
> So provide a kernel-parameter which a 'safe' default.
>
> partitions=strict
> is the default
> partitions=relaxed
> means that partitions are clipped rather than rejected.
> This kernel parameters only applies to auto-detected partitions,
> not those set by ioctl.
>
>
> Signed-off-by: Neil Brown <[email protected]>
>
> ### Diffstat output
> ./Documentation/kernel-parameters.txt | 8 ++++++++
> ./block/ioctl.c | 6 ++++++
> ./fs/partitions/check.c | 28 ++++++++++++++++++++++++++--
> 3 files changed, 40 insertions(+), 2 deletions(-)
>
> diff .prev/Documentation/kernel-parameters.txt ./Documentation/kernel-parameters.txt
> --- .prev/Documentation/kernel-parameters.txt 2006-10-16 10:03:40.000000000 +1000
> +++ ./Documentation/kernel-parameters.txt 2006-10-16 10:06:42.000000000 +1000
> @@ -1148,6 +1148,14 @@ and is between 256 and 4096 characters.
> Currently this function knows 686a and 8231 chips.
> Format: [spp|ps2|epp|ecp|ecpepp]
>
> + partitions= How to interpret partition information that
> + could be corrupt.
> + 'strict' is the default. Partitions that
> + don't fit in the device are rejected.
> + 'relaxed' is an option. Partitions that start
> + within the device be end beyond the end are
s/be/but/ ??
> + clipped.
> +
---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
