[PATCH] Re: [PATCH 1 of 2] Stackfs: Introduce stackfs_copy_{attr,inode}_*

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>On Friday 13 October 2006 07:18, Josef Jeff Sipek wrote:
>> +static inline void stackfs_copy_inode_size(struct inode *dst,
>> +					   const struct inode *src)
>> +{
>> +	i_size_write(dst, i_size_read((struct inode *)src));
>
>Instead of casting, I'd change the signature of i_size_read.


Change the signature of i_size_read(), IMINOR() and IMAJOR() because 
they, or the functions they call, will never modify the argument.
Compile-tested on x86 allmodconfig.

Signed-off-by: Jan Engelhardt <[email protected]>


Index: linux-2.6.19-rc1/include/linux/fs.h
===================================================================
--- linux-2.6.19-rc1.orig/include/linux/fs.h
+++ linux-2.6.19-rc1/include/linux/fs.h
@@ -633,7 +633,7 @@ enum inode_i_mutex_lock_class
  * cmpxchg8b without the need of the lock prefix). For SMP compiles
  * and 64bit archs it makes no difference if preempt is enabled or not.
  */
-static inline loff_t i_size_read(struct inode *inode)
+static inline loff_t i_size_read(const struct inode *inode)
 {
 #if BITS_PER_LONG==32 && defined(CONFIG_SMP)
 	loff_t i_size;
@@ -672,12 +672,12 @@ static inline void i_size_write(struct i
 #endif
 }
 
-static inline unsigned iminor(struct inode *inode)
+static inline unsigned iminor(const struct inode *inode)
 {
 	return MINOR(inode->i_rdev);
 }
 
-static inline unsigned imajor(struct inode *inode)
+static inline unsigned imajor(const struct inode *inode)
 {
 	return MAJOR(inode->i_rdev);
 }
#<EOF>


	-`J'
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux