Re: [PATCH 1 of 2] Stackfs: Introduce stackfs_copy_{attr,inode}_*

>> Many of these functions are too large to be inlined.  Suggest they be
>> placed in fs/fs-stack.c (or whatever we call it).

fs/stack.c would probably be enough -- fs/fs-stack.c is like
include/linux/reiserfs_fs.h

>Ack. As a rule of thumb, for functions like these (laundry list of
>assignments), what's a good threshold?

3 or 4 I guess. Might want to take a look at other static-inline functions.


	-`J'
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 0 of 2] Stackfs: generic stackable filesystem helper functions
    • From: Josef "Jeff" Sipek <[email protected]>
  • [PATCH 1 of 2] Stackfs: Introduce stackfs_copy_{attr,inode}_*
    • From: Josef "Jeff" Sipek <[email protected]>
  • Re: [PATCH 1 of 2] Stackfs: Introduce stackfs_copy_{attr,inode}_*
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 1 of 2] Stackfs: Introduce stackfs_copy_{attr,inode}_*
    • From: Josef Sipek <[email protected]>

• Prev by Date: Re: [0/3] 2.6.19-rc2: known regressions
• Next by Date: Re: [patch 6/6] mm: fix pagecache write deadlocks
• Previous by thread: Re: [PATCH 1 of 2] Stackfs: Introduce stackfs_copy_{attr,inode}_*
• Next by thread: Re: [PATCH 0 of 2] Stackfs: generic stackable filesystem helper functions
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]