Re: drivers/base/sys.c bug found

On Wed, Oct 04, 2006 at 07:38:07AM -0400, Jeff Garzik wrote:
> sysdev_driver::add is defined to return an error (as it should), but 
> that error code is never checked.

Ick, good catch.

I hate those sysdev devices...

Hm, in sysdev_driver_register() we don't want to return any error there,
as it doesn't make sense to.

Shaohua, sysdev devices should not stop the notificiation if a single
add() function returns an error, right?  All of the individual drivers
want to be notified of the device.

Bleah...did I mention I don't like these things...

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • drivers/base/sys.c bug found
    • From: Jeff Garzik <[email protected]>

• Prev by Date: Re: [PATCH] get_user_pages(..., write==1, ...) may return with readable pte.
• Next by Date: Re: patch [0/2]: acpi: add generic removable drive bay support
• Previous by thread: drivers/base/sys.c bug found
• Next by thread: [PATCH] drivers/base/bus: remove indentation level
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]