[PATCH] 2.6.19-rc1: Fix build breakage with CONFIG_PPC32

Linus
2.6.19-rc1 gives below error while compiling with CONFIG_PPC32.
===================================================================

LD      fs/built-in.o
GEN     .version
CHK     include/linux/compile.h
UPD     include/linux/compile.h
CC      init/version.o
LD      init/built-in.o
LD      .tmp_vmlinux1
arch/powerpc/platforms/built-in.o: In function `flush_disable_caches':
(.text+0x96d4): undefined reference to `low_cpu_die'
======================================================

low_cpu_die() is defined under CONFIG_PM || CONFIG_CPU_FREQ_PMAC options ,but while calling this function ,no care has been to taken to check these options. So please apply this fix,which solves the problem.

Signed-off-by: Srinivasa DS <[email protected]>

---
 arch/powerpc/platforms/powermac/smp.c |    7 +++++++
 1 file changed, 7 insertions(+)

Index: linux-2.6.19-rc1/arch/powerpc/platforms/powermac/smp.c
===================================================================
--- linux-2.6.19-rc1.orig/arch/powerpc/platforms/powermac/smp.c
+++ linux-2.6.19-rc1/arch/powerpc/platforms/powermac/smp.c
@@ -867,7 +867,14 @@ int smp_core99_cpu_disable(void)
 	return 0;
 }
 
+#if defined(CONFIG_PM) || defined(CONFIG_CPU_FREQ_PMAC)
 extern void low_cpu_die(void) __attribute__((noreturn)); /* in sleep.S */
+#else
+void low_cpu_die(void)
+{
+}
+#endif
+
 static int cpu_dead[NR_CPUS];
 
 void cpu_die(void)

---

• Follow-Ups:
  • Re: [PATCH] 2.6.19-rc1: Fix build breakage with CONFIG_PPC32
    • From: Paul Mackerras <[email protected]>

• Prev by Date: Re: [PATCH] HP mobile data protection system driver
• Next by Date: [PATCH 1/3] Add support for the generic backlight device to the IBM ACPI driver
• Previous by thread: [PATCH] HP mobile data protection system driver
• Next by thread: Re: [PATCH] 2.6.19-rc1: Fix build breakage with CONFIG_PPC32
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]