Re: [PATCH] serial: handle pci_enable_device() failure upon resume

On Wed, Oct 11, 2006 at 09:47:20PM -0400, Jeff Garzik wrote:
> Signed-off-by: Jeff Garzik <[email protected]>

NAK.  What happens to the ports if pci_enable_device() fails and someone
has them open?

It's far better to leave the must_check warning behind until it can be
_correctly_ solved, rather than papering over the problem with bogus
patches to return errors without taking an appropriate additional action.

IOW, the warnings serve as a reminder that *proper* error handling needs
to be implemented.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] serial: handle pci_enable_device() failure upon resume
    • From: Andrew Morton <[email protected]>

• References:
  • [PATCH] serial: handle pci_enable_device() failure upon resume
    • From: Jeff Garzik <[email protected]>

• Prev by Date: [PATCH] ecryptfs: use special_file
• Next by Date: Re: [PATCH] drivers/{mmc,misc}: handle PCI errors on resume
• Previous by thread: [PATCH] serial: handle pci_enable_device() failure upon resume
• Next by thread: Re: [PATCH] serial: handle pci_enable_device() failure upon resume
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]