Re: [PATCH] Readability improvement of open_exec()

> +	if (err)
> +		goto out;
> +
> +	inode = nd.dentry->d_inode;
> +	file = ERR_PTR(-EACCES);
> +	if ((nd.mnt->mnt_flags & MNT_NOEXEC) ||
> +	    !S_ISREG(inode->i_mode))

While you're cleaning up things you can put the whole if statement on
one line, it's less than 80 characters long.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Readability improvement of open_exec()
    • From: Casey Dahlin <[email protected]>

• References:
  • [PATCH] Readability improvement of open_exec()
    • From: Casey Dahlin <[email protected]>

• Prev by Date: Re: [patch 5/7] fault-injection capability for disk IO
• Next by Date: Re: Realtime Wiki - http://rt.wiki.kernel.org
• Previous by thread: [PATCH] Readability improvement of open_exec()
• Next by thread: Re: [PATCH] Readability improvement of open_exec()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]