Re: [PATCH] SPI: improve sysfs compiler complaint handling

[David Brownell <david-b@pacbell.net>]

On Thursday 12 October 2006 11:24 am, Andrew Morton wrote:
> On Thu, 12 Oct 2006 11:08:59 -0700
> David Brownell <david-b@pacbell.net> wrote:
> 
> > On Wednesday 11 October 2006 6:49 pm, Jeff Garzik wrote:
> > 
> > > The compiler complains, even with the "(void)".
> > 
> > > -	(void) device_for_each_child(master->cdev.dev, NULL, __unregister);
> > 
> > Sure seems like a compiler bug to me.
> 
> Seems like a kernel bug to me.  Look at device_del() and weep.  It calls
> eighty eight things which can fail, some of which randomly return void but
> shouldn't, then drops the overall result on the floor.

That's an isssue too, but it's separate from the one I was describing
(wherein warnings are wrongly issued in the long-established idiom of
"casting into the void").  That compiler bug is causing lots of crap
to be added all over the kernel.

As you implicitly observed, the __unregister() routine really can't
do a thing with faults; it calls "void device_unregister()", which
in turn calls device_del() etc. 


> So if something failed and you come up and reinsert the device or driver
> two days later the kernel collapses in a heap and you don't have a clue
> why.
> 
> You're just a victim of all this.

Well, not me personally but "we" collectively as kernel developers.


> Who wrote all this stuff, and what were they thinking?

I suspect what they were thinking was the old "if you can't figure out
how to handle the error, don't test for it" thing.  I've never quite
agreed that so many cleanup-path routines should return void.  It's not
as if they _can't_ hit failures.  Or that some of those failures can't
be coped with by at stopping further attempts at cleanup...

- Dave

 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/