Re: [PATCH 3/3] drivers/scsi/NCR5380.c: Replacing yield() with a better alternative

> You want cond_resched() for this driver as its polling the hardware for
> a change that should occur very soon. (Actually you want to throw the
> hardware in the bin)
> 

Replaced schedule_timeout_interruptible() with cond_resched()

Signed-off-by: Amol Lad <[email protected]>
---
diff -uprN -X linux-2.6.19-rc1-orig/Documentation/dontdiff linux-2.6.19-rc1-orig/drivers/scsi/NCR5380.c linux-2.6.19-rc1/drivers/scsi/NCR5380.c
--- linux-2.6.19-rc1-orig/drivers/scsi/NCR5380.c	2006-09-21 10:15:39.000000000 +0530
+++ linux-2.6.19-rc1/drivers/scsi/NCR5380.c	2006-10-11 17:57:02.000000000 +0530
@@ -347,7 +347,7 @@ static int NCR5380_poll_politely(struct 
 		if((r & bit) == val)
 			return 0;
 		if(!in_interrupt())
-			yield();
+			cond_resched();
 		else
 			cpu_relax();
 	}


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 3/3] drivers/scsi/NCR5380.c: Replacing yield() with a better alternative
    • From: Amol Lad <[email protected]>
  • Re: [PATCH 3/3] drivers/scsi/NCR5380.c: Replacing yield() with a better alternative
    • From: Alan Cox <[email protected]>

• Prev by Date: Re: [PATCH 0/9] i386-pda: Updated i386 PDA patches against 2.6.19-rc1-mm1
• Next by Date: Re: [PATCH] hwmon/abituguru: handle sysfs errors
• Previous by thread: Re: [PATCH 3/3] drivers/scsi/NCR5380.c: Replacing yield() with a better alternative
• Next by thread: [PATCH 1/3] drivers/scsi/ibmmca.c: Replacing yield() with a better alternative
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]