Re: [PATCH 2/2] ioc4: Enable build on non-SN2

[Jan Engelhardt <jengelh@linux01.gwdg.de>]

>> Mostly curious:  did you observe that this is required?
>> I always thought that Roman said that unknown config variables
>> caused a rescan by kconfig.  IOW, I thought that it wouldn't
>> be observable by a user.  Just wondering..
>
>If it causes a rescan (I don't rightly know) it must have changed.
>I caught a bit of flak for an incorrectly ordered config statement
>once before, but that was a few years ago.

I am sure it causes a rescan, because activating 
CONFIG_NETFILTER for example makes some options available that are 
defined before NETFILTER, such as IP_ROUTE_FWMARK, IP_VS, 
NETFILTER_XT_TARGET_CONNMARK and NETFILTER_XT_TARGET_NOTRACK, and 
activating NETFILTER _will_ cause a rescan with `make oldconfig` - I 
just tried. (Things are a little different with menuconfig/xconfig and 
such of course)

>> The lines under ---help--- should be indented by 2 spaces (by
>> convention) (and even though they were not when in the /sn/ subdir).
>
>Thanks for catching that... I just blindly copied from one spot
>to another.  I'll resend.

Not tabs?


	-`J'
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/