Re: [PATCH] ixgb.h: Redefine IXGB_DBG() macro to use pr_debug().

On Tue, 2006-10-10 at 07:17 -0400, Robert P. J. Day wrote:
> Simplify the definition of IXGB_DBG() to be based on pr_debug().
> 
> Signed-off-by: Robert P. J. Day <[email protected]>
> ---
> diff --git a/drivers/net/ixgb/ixgb.h b/drivers/net/ixgb/ixgb.h
> index 50ffe90..16e6c3d 100644
> --- a/drivers/net/ixgb/ixgb.h
> +++ b/drivers/net/ixgb/ixgb.h
> @@ -77,11 +77,7 @@ #include "ixgb_hw.h"
>  #include "ixgb_ee.h"
>  #include "ixgb_ids.h"
> 
> -#ifdef _DEBUG_DRIVER_
> -#define IXGB_DBG(args...) printk(KERN_DEBUG "ixgb: " args)
> -#else
> -#define IXGB_DBG(args...)
> -#endif
> +#define IXGB_DBG(args...) pr_debug("ixgb: ", args)


while this is of course correct, why not go all the way and replace all
IXGB() users to pr_debug() directly? 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] ixgb.h: Redefine IXGB_DBG() macro to use pr_debug().
    • From: "Robert P. J. Day" <[email protected]>

• References:
  • [PATCH] ixgb.h: Redefine IXGB_DBG() macro to use pr_debug().
    • From: "Robert P. J. Day" <[email protected]>

• Prev by Date: Re: [stable] [PATCH 2.6.19-rc1] drivers/media/dvb/bt8xx/dvb-bt8xx.c: check kmalloc() return value.
• Next by Date: Re: [PATCH] ixgb.h: Redefine IXGB_DBG() macro to use pr_debug().
• Previous by thread: [PATCH] ixgb.h: Redefine IXGB_DBG() macro to use pr_debug().
• Next by thread: Re: [PATCH] ixgb.h: Redefine IXGB_DBG() macro to use pr_debug().
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]