Jean Delvare wrote:
Hi Hans, Jeff,
You (Jean) already mailed me about this and it was on my todo list,
but I'm currently rather busy with work. So it looks like Jeff beat
me to it.
Jeff's patch looks fine, please apply. Thanks Jeff!
The patch isn't wrong per se, but it could be made more simple, and is
incomplete in comparison to what was done for all other hardware
monitoring drivers:
* We want to create all the files before registering with the hwmon
class, this closes a race condition.
OK
* We want to delete all the device files at regular cleanup time (after
unregistering with the hwmon class).
Is this really nescesarry? AFAIK the files get deleted when the device gets deleted.
* It's OK to call device_create_file() on a non-existent file, so the
error path can be simplified.
?? You mean device_remove_file I assume?
I'd like the abituguru driver to behave the same as all other hardware
monitoring drivers to lower the maintenance effort. Can either you
or Jeff work up a compliant patch?
I understand Jeff any chance you can do a new revision of your patch? Otherwise I'll take care of it as time permits.
Regards,
Hans
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
