Re: driver,platform,firmware,system, data data data ....

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Tue, 2006-10-10 at 07:48 +0200, Rene Herman wrote:
> Benjamin Herrenschmidt wrote:
> 
> [ device->platform_data ]
> 
> > So except for the size of the patch and boredom of going through all
> > of them fixing them, do you see any reason why this later one
> > shouldn't be moved out to platform_driver ? (I haven't actually
> > checked at all the occurences in the tree though).
> 
> You'll find it being used in drivers/base/isa.c for one. I only used it 
> there because it was available and made for slightly nicer code though. 
> If platform_data is going away (and assuming you wouldn't want similar 
> abuse of your new system_data) it wouldn't be a problem to move the 
> driver pointer to the private struct isa_dev as in the attached.

Ah thanks, I missed that use.

Well, we'll see what Greg has to say but thanks for the patch.

Cheers,
Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/