Re: Panic in pci_call_probe from 2.6.18-mm2 and 2.6.18-mm3

[Badari Pulavarty <pbadari@us.ibm.com>]

On Sun, 2006-10-08 at 00:02 -0700, Martin J. Bligh wrote:
> Not sure if you've seen this already ... catching up on test results.
> 
> This was on NUMA-Q, on both -mm2 and -mm3. -mm1 didn't suffer from this
> problem.
> 
> Full logs:
> 
> mm2 - http://test.kernel.org/abat/50727/debug/console.log
> mm3 - http://test.kernel.org/abat/51442/debug/console.log
> 
> config - http://test.kernel.org/abat/51442/build/dotconfig
> 
> I'm guessing from the 00000004 that the pcibus_to_node(dev->bus)
> is failing because bus->sysdata is NULL. The disassembly and
> structure offsets seem to line up for that.
> 
> #define pcibus_to_node(bus) (
> 	(struct pci_sysdata *)((bus)->sysdata))->node
> 
> struct pci_sysdata {
>          int             domain;         /* PCI domain */
>          int             node;           /* NUMA node */
> };
> 

Martin,

Jeff moved "node" to a proper field in sysdata, instead
of overloading sysdata itself. I think this is causing the
problem. I guess we could end up with sysdata = NULL in some
cases ? Since you are the NUMA-Q expert, where does sysdata 
gets set for NUMA-Q ? :)

-mm2 changed:

#define pcibus_to_node(bus) ((long) (bus)->sysdata)

to 

#define pcibus_to_node(bus) ((struct pci_sysdata *)((bus)->sysdata))-
>node


Thanks,
Badari


> BUG: unable to handle kernel NULL pointer dereference at virtual address 
> 00000004
>   printing eip:
> c02060d4
> *pde = 0042c001
> *pte = 00000000
> Oops: 0000 [#1]
> SMP
> last sysfs file:
> Modules linked in:
> CPU:    2
> EIP:    0060:[<c02060d4>]    Not tainted VLI
> EFLAGS: 00010286   (2.6.18-mm2-autokern1 #1)
> EIP is at pci_call_probe+0x19/0xb5
> eax: 00000000   ebx: e778b400   ecx: e7400030   edx: c03b89a0
> esi: e778b400   edi: 0000ffff   ebp: e69a2fa0   esp: e740dea4
> ds: 007b   es: 007b   ss: 0068
> Process swapper (pid: 1, ti=e740c000 task=e7400030 task.ti=e740c000)
> Stack: ffffffed e778b400 c03b89a0 c02061a3 c03b89a0 e778b400 c03b873c 
> c03b89a0
>         e778b400 c03b89d4 c02061d6 c03b89a0 e778b400 e778b400 c03b89d4 
> e778b448
>         c0224800 e778b448 c03b89d4 e778b448 00000000 c03b89d4 c0224936 
> e69a2fa0
> Call Trace:
>   [<c02061a3>] __pci_device_probe+0x33/0x47
>   [<c02061d6>] pci_device_probe+0x1f/0x34
>   [<c0224800>] really_probe+0x31/0xb9
>   [<c0224936>] driver_probe_device+0x93/0x9c
>   [<c02249b5>] __driver_attach+0x0/0x7c
>   [<c02249fc>] __driver_attach+0x47/0x7c
>   [<c0223e98>] bus_for_each_dev+0x47/0x6d
>   [<c01fd05a>] kobject_add+0xa9/0xf2
>   [<c0224a45>] driver_attach+0x14/0x18
>   [<c02249b5>] __driver_attach+0x0/0x7c
>   [<c022437b>] bus_add_driver+0x53/0xd0
>   [<c0224d99>] driver_register+0x74/0x77
>   [<c02063ea>] __pci_register_driver+0x6b/0x7a
>   [<c04146c3>] qla1280_init+0xc/0xf
>   [<c04007ff>] do_initcalls+0x55/0xe8
>   [<c0184095>] proc_mkdir+0x12/0x16
>   [<c0135136>] init_irq_proc+0x21/0x2f
>   [<c01003b8>] init+0x0/0x148
>   [<c010040d>] init+0x55/0x148
>   [<c01033c7>] kernel_thread_helper+0x7/0x10
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/