Re: [PATCH 2.6.19-git] Fix error handling in create_files()

On Mon, Oct 09, 2006 at 06:40:17PM +0200, Luca Tettamanti wrote:
> Hello,
> current code in create_files() detects an error iff the last
> sysfs_add_file fails:
> 
> for (attr = grp->attrs; *attr && !error; attr++) {
>         error = sysfs_add_file(dir, *attr, SYSFS_KOBJ_ATTR);
> }
> if (error)
>         remove_files(dir,grp);
> 
> In order to do the proper cleanup upon failure 'error' must be checked on
> every iteration.

But it is, look up there in the "!error" test, right?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 2.6.19-git] Fix error handling in create_files()
    • From: Luca Tettamanti <[email protected]>

• References:
  • [PATCH 2.6.19-git] Fix error handling in create_files()
    • From: Luca Tettamanti <[email protected]>

• Prev by Date: Re: [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel [try #4]
• Next by Date: Re: [PATCH] MMC: Select only one voltage bit in OCR response
• Previous by thread: [PATCH 2.6.19-git] Fix error handling in create_files()
• Next by thread: Re: [PATCH 2.6.19-git] Fix error handling in create_files()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]