Re: [PATCH 2.6.19-rc1] drivers/media/dvb/bt8xx/dvb-bt8xx.c: check kmalloc() return value.

[Manu Abraham <abraham.manu@gmail.com>]

Olaf Hering wrote:
> On Sun, Oct 08, Amit Choudhary wrote:
> 
>> Description: Check the return value of kmalloc() in function frontend_init(), in file drivers/media/dvb/bt8xx/dvb-bt8xx.c.
>>
>> Signed-off-by: Amit Choudhary <amit2030@gmail.com>
>>
>> diff --git a/drivers/media/dvb/bt8xx/dvb-bt8xx.c b/drivers/media/dvb/bt8xx/dvb-bt8xx.c
>> index fb6c4cc..14e69a7 100644
>> --- a/drivers/media/dvb/bt8xx/dvb-bt8xx.c
>> +++ b/drivers/media/dvb/bt8xx/dvb-bt8xx.c
>> @@ -665,6 +665,10 @@ static void frontend_init(struct dvb_bt8
>>  	case BTTV_BOARD_TWINHAN_DST:
>>  		/*	DST is not a frontend driver !!!		*/
>>  		state = (struct dst_state *) kmalloc(sizeof (struct dst_state), GFP_KERNEL);
>> +		if (!state) {
>> +			printk("dvb_bt8xx: No memory\n");
> 
> KERN_FOO loglevel is missing.

It shouldn't matter though.


Manu


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/