Re: + clocksource-add-generic-sched_clock.patch added to -mm tree

[Daniel Walker <dwalker@mvista.com>]

On Sun, 2006-10-08 at 17:46 +0200, Thomas Gleixner wrote:
> On Sun, 2006-10-08 at 08:32 -0700, Daniel Walker wrote:
> > > sched_clock is a user of the clocksource API and there is absolutely no
> > > reason to put that into sched.c
> > 
> > We could do something like kernel/time/sched_clock.c ? I really don't
> > like the idea of stuff sched_clock() , and timekeeping back into
> > clocksource.
> 
> Do we really want 3 files which each has 50 lines of code ? Although
> it's better than pushing that stuff into sched.c and timer.c. timer.c is
> enough mess and we really do not want to add more.

I think John's plan, and my plan, is to move the generic time bits, plus
the timekeeping specific clocksource stuff, into a different file.
kernel/timer.c shouldn't have that stuff anyway. That's about 250 lines,
the part of that which is due to the clocksource is about 100 lines.

Are you thinking that this interface is only likely to have one or two
users?

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/