Re: [patch 2/3] mm: fault vs invalidate/truncate race fix

On Sat,  7 Oct 2006 15:06:21 +0200 (CEST)
Nick Piggin <[email protected]> wrote:

> Fix the race between invalidate_inode_pages and do_no_page.

- In do_no_page() there's a `goto retry' where we appear to have
  forgotten to (conditionally) unlock the page.

- In do_no_page() the COW-break code seem to have forgotten to
  (conditionally) unlock the page which it just COWed?

- In do_no_page(), the unlock_page() which _is_ there doesn't test
  VM_CAN_INVALIDATE before deciding to unlock the page.

I have a bad feeling that I'm not getting the point here...

<looks>

Ah, it appears you've fixed at least some of these things in the next
patch.  Tricky.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 2/3] mm: fault vs invalidate/truncate race fix
    • From: Nick Piggin <[email protected]>

• References:
  • [rfc] 2.6.19-rc1: vm stuff
    • From: Nick Piggin <[email protected]>
  • [patch 2/3] mm: fault vs invalidate/truncate race fix
    • From: Nick Piggin <[email protected]>

• Prev by Date: Re: [patch 3/3] mm: fault handler to replace nopage and populate
• Next by Date: Re: [PATCH 5/5] ioremap balanced with iounmap for drivers/char/watchdog/s3c2410_wdt.c
• Previous by thread: Re: [patch 2/3] mm: fault vs invalidate/truncate race fix
• Next by thread: Re: [patch 2/3] mm: fault vs invalidate/truncate race fix
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]